qwc-open/asiakirjat
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 25 Packages 1 Wiki Activity Actions

Fix DeleteExpired timezone mismatch with SQLite #93

Merged
qwc merged 1 commit from fix/session-delete-expired-timezone into main 2026-03-17 13:57:01 +01:00
Conversation 0 Commits 1 Files changed 1 +3 -2
qwc commented 2026-03-17 13:56:07 +01:00
Owner
Copy link

Summary

  • DeleteExpired used SQL CURRENT_TIMESTAMP (UTC in SQLite) to compare against session expiry times stored via Go's time.Now() (local timezone)
  • On servers ahead of UTC, expired sessions were not being cleaned up because they appeared "in the future" relative to UTC
  • Fix: pass time.Now().UTC() as a query parameter instead of relying on CURRENT_TIMESTAMP

Test plan

  • TestSessionStoreDeleteExpired passes
  • Full test suite passes (368 tests)

🤖 Generated with Claude Code

## Summary - `DeleteExpired` used SQL `CURRENT_TIMESTAMP` (UTC in SQLite) to compare against session expiry times stored via Go's `time.Now()` (local timezone) - On servers ahead of UTC, expired sessions were not being cleaned up because they appeared "in the future" relative to UTC - Fix: pass `time.Now().UTC()` as a query parameter instead of relying on `CURRENT_TIMESTAMP` ## Test plan - [x] `TestSessionStoreDeleteExpired` passes - [x] Full test suite passes (368 tests) 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
Fix DeleteExpired timezone mismatch with SQLite
All checks were successful
CI / test (pull_request) Successful in 1m19s
Details
CI / build (pull_request) Successful in 51s
Details
CI / docker (pull_request) Has been skipped
Details
42d0287207 
CURRENT_TIMESTAMP is UTC in SQLite, but sessions are stored with
local time. Pass time.Now().UTC() as a parameter instead so the
comparison is consistent regardless of server timezone.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
qwc merged commit 201ef0e088 into main 2026-03-17 13:57:01 +01:00
qwc deleted branch fix/session-delete-expired-timezone 2026-03-17 13:57:01 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
qwc-open/asiakirjat!93
No description provided.