Add PDF documentation upload support #72

Open

qwc wants to merge 5 commits from feature/pdf-upload-support into main

pull from: feature/pdf-upload-support

merge into: qwc-open:main

qwc-open:main

Conversation 1 Commits 5 Files changed 42 +8078 -174

qwc commented 2026-02-16 18:08:09 +01:00

Owner

Copy link

Summary

Implements PDF upload support as requested in #68.

• Database: New migration (007) adds content_type column to versions table, defaulting to 'archive' for existing rows
• Upload: Both web UI and API endpoints detect .pdf files by filename extension, store the PDF as document.pdf in the version directory instead of extracting an archive
• Serving: PDF versions render in an HTML wrapper page with <embed> tag, preserving the overlay toolbar (version selector, search, navigation all work normally)
• Download: PDF versions serve the raw PDF file directly instead of generating a ZIP
• Version list: PDF versions show a red "PDF" badge and contextual download label
• Search: PDF versions are silently skipped during Bleve indexing (no text extraction library yet)

Not in scope (deferred per #68)

• Full-text search of PDF content
• Diff comparison for PDF versions

Test plan

• Upload a PDF via the web UI — verify it appears in version list with "PDF" badge
• Click the PDF version link — verify PDF opens in browser with overlay toolbar
• Upload an archive version to the same project — verify both types coexist
• Download a PDF version — verify raw PDF is served (not zipped)
• Re-upload a version changing type (archive → PDF or vice versa) — verify it works
• Verify search doesn't crash (PDF versions silently skipped)
• go test ./... passes

🤖 Generated with Claude Code

## Summary Implements PDF upload support as requested in #68. - **Database**: New migration (007) adds `content_type` column to `versions` table, defaulting to `'archive'` for existing rows - **Upload**: Both web UI and API endpoints detect `.pdf` files by filename extension, store the PDF as `document.pdf` in the version directory instead of extracting an archive - **Serving**: PDF versions render in an HTML wrapper page with `<embed>` tag, preserving the overlay toolbar (version selector, search, navigation all work normally) - **Download**: PDF versions serve the raw PDF file directly instead of generating a ZIP - **Version list**: PDF versions show a red "PDF" badge and contextual download label - **Search**: PDF versions are silently skipped during Bleve indexing (no text extraction library yet) ### Not in scope (deferred per #68) - Full-text search of PDF content - Diff comparison for PDF versions ## Test plan - [ ] Upload a PDF via the web UI — verify it appears in version list with "PDF" badge - [ ] Click the PDF version link — verify PDF opens in browser with overlay toolbar - [ ] Upload an archive version to the same project — verify both types coexist - [ ] Download a PDF version — verify raw PDF is served (not zipped) - [ ] Re-upload a version changing type (archive → PDF or vice versa) — verify it works - [ ] Verify search doesn't crash (PDF versions silently skipped) - [ ] `go test ./...` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code)

qwc added 1 commit 2026-02-16 18:08:10 +01:00

Add PDF documentation upload support (#68) ... 5143421496

Accept .pdf file uploads alongside archives. PDF versions are stored as
a single file and served in an HTML wrapper with the overlay toolbar.
Search indexing is skipped for PDF versions (no text extraction yet).

- Add content_type column to versions (migration 007)
- Detect PDF uploads in web and API handlers
- Serve PDF in embedded viewer with overlay
- Show PDF badge in version list, serve raw PDF on download
- Update upload form to accept .pdf files

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

qwc referenced this pull request 2026-02-16 18:27:40 +01:00

Add PDF full-text search and diff denial #73

qwc added 2 commits 2026-02-16 18:29:38 +01:00

Add PDF full-text search and graceful diff denial ... 2305cb4f5e

- Extract text from PDFs for Bleve search indexing using pdftotext
  (poppler-utils) with pure Go fallback (ledongthuc/pdf)
- Add poppler-utils to Docker runtime image for best extraction quality
- Re-enable search indexing for PDF uploads (was skipped in #68)
- Add content_type to versions API so overlay JS knows which are PDFs
- Block diff comparison for PDF versions with clear error message
  instead of confusing "Could not find content area" failure

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge pull request 'Add PDF full-text search and diff denial' (#73) from feature/pdf-search-and-diff-denial into feature/pdf-upload-support ... e5fdb8ca33

Reviewed-on: #73

qwc added 1 commit 2026-02-17 08:33:11 +01:00

Fix built-in documentation gaps and inaccuracies ... 2026455ce9

- Fix config field names (host->address, user_base_dn->base_dn, storage default)
- Rewrite LDAP/OAuth2 config docs to match actual config.go fields
- Add PDF upload support documentation across all relevant pages
- Add retention, proxy_strip_path, log_level config documentation
- Fix editor role: can create projects (not just admin)
- Add 100 MB upload size limit (was incorrectly "no hard-coded limit")
- Add version diffing and PDF support to feature list

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

qwc commented 2026-02-17 08:33:24 +01:00

Author

Owner

Copy link

Added comprehensive built-in documentation fixes (commit 2026455):

• Fixed config field names throughout (host→address, user_base_dn→base_dn, storage default data/docs→data/projects)
• Rewrote LDAP and OAuth2 config docs to match actual config.go fields (removed non-existent fields like username_attr, provider, claims.*, nested tls:)
• Added PDF upload support documentation across tutorials, reference, and explanation pages
• Added retention, proxy_strip_path, log_level config documentation
• Fixed editor role permissions: can create projects (not just admin)
• Corrected upload size limit (100 MB, was "no hard-coded limit")
• Added version diffing and PDF support to feature list on index page

11 files changed, 210 insertions, 135 deletions.

Added comprehensive built-in documentation fixes (commit 2026455): - Fixed config field names throughout (`host`→`address`, `user_base_dn`→`base_dn`, storage default `data/docs`→`data/projects`) - Rewrote LDAP and OAuth2 config docs to match actual `config.go` fields (removed non-existent fields like `username_attr`, `provider`, `claims.*`, nested `tls:`) - Added PDF upload support documentation across tutorials, reference, and explanation pages - Added retention, `proxy_strip_path`, `log_level` config documentation - Fixed editor role permissions: can create projects (not just admin) - Corrected upload size limit (100 MB, was "no hard-coded limit") - Added version diffing and PDF support to feature list on index page 11 files changed, 210 insertions, 135 deletions.

qwc added 1 commit 2026-02-17 10:49:49 +01:00

Merge remote-tracking branch 'origin/main' into feature/pdf-upload-support ... 504da92101

# Conflicts:
#	internal/docs/builtin/docs/how-to/configure-ldap.md
#	internal/docs/builtin/docs/reference/configuration.md

All checks were successful

Hide all checks

Release / docker (push) Successful in 1m13s

Details

CI / docker (pull_request) Has been skipped

Details

Release / notify (push) Successful in 1s

Details

CI / test (pull_request) Successful in 56s

Details

Release / test (push) Successful in 56s

Details

CI / build (pull_request) Successful in 42s

Details

Release / release (push) Successful in 1m7s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature/pdf-upload-support:feature/pdf-upload-support

git switch feature/pdf-upload-support

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

qwc-open/asiakirjat!72

No description provided.